Feature Request: Use application.process.binary when application.name is an empty string

maltejur / discord-screenaudio

A custom discord client that supports streaming with audio on Linux.

1.1k stars 35 forks source link

Feature Request: Use application.process.binary when application.name is an empty string #89

Closed edisionnano closed 1 year ago

edisionnano commented 1 year ago

Some games on proton like Resident Evil or Deltarune have an empty application.name, the value of application.process.binary is wine64-preloader and it would be a good idea to show that instead. Example from Resident Evil 7

maltejur commented 1 year ago

Sure. I've updated the code and pushed it to the master branch. Could you test it and check if it works with your games?

Jeames8kin commented 1 year ago

Hey mate, just built master and checked with RE7 and RE2 with no success. No other programs apart from the ones with names show up so far, I might have to delve a little further as I just woke up.

Reading the output for virtmic doesn't seem to want to touch any program without a name either, so it's possibly not doing what we want it to. Screenshot below shows discord-screenaudio output, Discord itself being unable to find the game with the game running.

If you need more details/information, let me know and I'll be happy to provide anything else, as I was the one with this issue initially (thanks to @edisionnano for opening this issue).

Resident_Evil_7_Discord_Screenaudio

maltejur commented 1 year ago

I am having trouble trying to reproduce your problem. Even if I use the version of discord-screenaudio without the patch, everything works just fine:

I am using the demo versions of the game here. Can you check if the demo version of RE7 also works for you?

Jeames8kin commented 1 year ago

Alright, so I just tested the demo and that shows up fine, but it actually has an entry under application.name, and on a technical level the demo of RE7 uses an older version of the RE Engine, before they changed it to DX12 and updated something regarding the audio, which RE2 got as well.

Are you using the DX11 version or the DX12 version of RE2? Might redownload the DX11 version to see if that's possibly the issue, as I don't think I recall this being a problem before the update now I come to think of it.

maltejur commented 1 year ago

Okay I just bought RE2 and 3, I wanted to play them sometime anyways and they are pretty cheap currently :D

With that I could reproduce your issue and fix it for real this time.

The changes are pushed to the master branch and you should be able to test them.

Jeames8kin commented 1 year ago

Something about the most recent RE Engine update has done something with the audio side of things, as the DX11 shows completely fine as shown in the screenshot below. Seems to be an RE Engine related issue, as all RE7, RE2 and RE3 are affected.

RE2_Discord_Screenaudio

I'll give the master branch another shot, however from my observation the no application.name issue stems from the latest RE Engine update to DirectX 12.

Jeames8kin commented 1 year ago

Yep, that definitely fixed it. Wine64-preloader shows up fine, game audio sounds fine to me through another Discord client, and it's the DX12 version. RE7_Discord_Screenaudio_Fixed Thanks for your (very quick) help, and enjoy the RE games! They're good fun to play, although I wish RE3 had a bit more time in the making, but it's still an alright game nonetheless. Hoping for RE4 Remake to be good, it's got me curious with their current approach to it.