Code Cleanup - Githubissues

maltejur / discord-screenaudio

A custom discord client that supports streaming with audio on Linux.

1.09k stars 35 forks source link

Code Cleanup #97

Open maltejur opened 1 year ago

maltejur commented 1 year ago

If I find the time, the code is in dire need of a cleanup. Main things to do:

[x] Use QWebChannel for communicating between the userscript and the main process instead of the hacky one-way console communication I am doing right now
[ ] Update the virmic code to use the latest version of rohrkabel (https://github.com/maltejur/discord-screenaudio/issues/26) and avoid creating a new process for the virtmic
[ ] Improve the way UI elements are injected into the dom

ghost commented 1 year ago

any update? I've seen progress on the virtmic since that time i stupidly tried to push for that merge request.

Curve commented 11 months ago

Shameless plug right here, but for the Userscript communication you might be interested in saucer ^^

maltejur commented 11 months ago

Ohh, interesting. As I mentioned, I have switched over to QWebChannel a while ago, so the cross-communication is not as bad as it used to be, and I probably want to stick with QWebChannel for now. But definitely looks nice, maybe I'll have the chance to try it with a new project at some point.