search

maltezfaria / DataFlowTasks.jl

Tasks which can keep track of how data flows through it
https://maltezfaria.github.io/DataFlowTasks.jl/
MIT License
28 stars 1 forks source link

Update to Makie 0.20 #88

Open ffevotte opened 9 months ago

ffevotte commented 9 months ago

It looks like the profile plot must be updated for Makie 0.20, at least to avoid using the deprecated resolution keyword. There are possibly other tweaks to make...

maltezfaria commented 9 months ago

I tried it locally and it worked... maybe I was on the wrong version of Makie

I am going to revert the last commit on main, and we can later open a PR to fix this.

ffevotte commented 9 months ago

It's OK for now: it's merely a warning and we can always fix this later. I think we just don't want to release a patch version without fixing this first.

maltezfaria commented 9 months ago

Ok. The CI did work with the latest Makie:

https://github.com/maltezfaria/DataFlowTasks.jl/actions/runs/6978168705/job/18989110560

ffevotte commented 9 months ago

Yes. The deprecation warning can be seen e.g. here, in cell [10]: https://nbviewer.org/github/maltezfaria/DataFlowTasks.jl/blob/gh-pages/dev/examples/cholesky/cholesky.ipynb

But (1) it works, and (2) I think the warning does not even show up in the documentation pages. So we're fine for now: no need to revert the commit IMO, but no need to rush to a fix either.