malthe / pq

A PostgreSQL job queueing system
376 stars 41 forks source link

Add create.sql to package data #22

Closed billymillions-zz closed 7 years ago

billymillions-zz commented 7 years ago

Distribution does not currently deploy create.sql (with pip 9.0.1).

alexanderad commented 7 years ago

Hey, @malthe, do you think we can get a new version of pq uploaded to pypi? We have same issue here. Thanks @billymillions!

alexanderad commented 7 years ago

I'm not sure if this is related directly, but we have built a package from master and we are getting:

Collecting pq (from ...)
  Downloading https://....<private repo>.../packages/pq-1.5.dev0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-4CPO2B/pq/setup.py", line 24, in <module>
        long_description='\n\n'.join(map(readfile, ('README.rst', 'CHANGES.rst'))),
      File "/tmp/pip-build-4CPO2B/pq/setup.py", line 12, in readfile
        f = open(name)
    IOError: [Errno 2] No such file or directory: 'CHANGES.rst'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-4CPO2B/pq/
malthe commented 7 years ago

I know that at least historically, setuptools needed support in understanding a source control system (e.g. git or subversion) to know which files should be in the manifest.

It might be that we need to be more explicit in the package_data query.

alexanderad commented 7 years ago

@malthe, we desperately needed a valid package, so I went ahead and fixed the thing with MANIFEST approach. I'm presenting that as a PR, but I'm okay you closing it if you find a better/valid way to get the package built with all the needed files via sdist.