Closed alexanderad closed 7 years ago
Going to copy a comment I left on #22. We desperately needed a valid package, so I went ahead and fixed the thing with MANIFEST approach. I'm presenting that as a PR, but I'm okay @malthe closing it in favor of anything better/valid to get the package built with all the needed files via sdist
.
I think MANIFEST
is a reasonable solution – it's possible to generate it even (if one wanted to).
This is a follow up of: https://github.com/malthe/pq/pull/22 I experimented with
package_data
and evendata_files
, but after all I failed to getsdist
to build a valid package withcreate.sql
andCHANGES.rst
.Finally I got to MANIFEST approach: https://docs.python.org/2/distutils/sourcedist.html#manifest-related-options
And got the package successfully built: