search

maltize / sublime-text-2-ruby-tests

Sublime Text 2 plugin for running ruby tests! (Unit, RSpec, Cucumber)
722 stars 119 forks source link

Ensure RubyTest works with Sublime Text 3 #148

Open gja opened 11 years ago

gja commented 11 years ago

Lots of new changes in the ChangeLog:

http://www.sublimetext.com/3

The only one that looks urgent is the fact that begin_edit and end_edit are missing.

API: Upgraded from Python 2.6 to Python 3.3 API: Plugins run out-of-process API: Plugin API is now threadsafe API: Some API events are now run asynchronously API: begin_edit() / end_edit() are no longer accessible API: Projects are exposed to the API API: Added window.settings() and window.template_settings() API: show_quick_panel accepts an on_highlighted callback

maltize commented 11 years ago

Looks like the plugin core functionality is working on Sublime Text 3. No colors but it's not a big issue :)

gs commented 11 years ago

thats a great news!!!

gja commented 11 years ago

Can you also test if the 'extract local variable' works correcly?

I saw that begin_edit and end_edit are the ones that became deprecated

On Thu, Jan 31, 2013 at 8:54 PM, Grzegorz Smajdor notifications@github.comwrote:

thats a great news!!!

— Reply to this email directly or view it on GitHubhttps://github.com/maltize/sublime-text-2-ruby-tests/issues/148#issuecomment-12947380.

gs commented 11 years ago

Hi, I've checked the 'extract local variable'. It fails with below message:

File "/Users/Grzegorz/Library/Application Support/Sublime Text 3/Packages/RubyTest/run_ruby_test.py", line 359, in self.window().show_input_panel("Variable Name: ", '', lambda name: self.generate(selection, name), None, None) File "/Users/Grzegorz/Library/Application Support/Sublime Text 3/Packages/RubyTest/run_ruby_test.py", line 365, in generate edit = self.view.begin_edit() TypeError: begin_edit() missing 2 required positional arguments: 'edit_token' and 'cmd'

jfernandez commented 11 years ago

Any updates on Sublime 3 support?

mhenrixon commented 11 years ago

:+1:

onetom commented 11 years ago

The "ruby_use_scratch" option is also using the old begin_edit() API:

Running cucumber features/xxxxx.feature -l9 | unexpand -t 2
Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 549, in run_
    return self.run(edit)
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 319, in run
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 167, in run_shell_command
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 172, in display_results
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 37, in display_results
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 47, in append
TypeError: begin_edit() missing 2 required positional arguments: 'edit_token' and 'cmd'
reloading Packages/User/RubyTest.last-run
Traceback (most recent call last):
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 58, in copy_stuff
  File "/Users/onetom/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package/run_ruby_test.py", line 47, in append
TypeError: begin_edit() missing 2 required positional arguments: 'edit_token' and 'cmd'

it would be soooo nice to get this working... :)

Jayphen commented 10 years ago

Is this still not working?

brandonparsons commented 10 years ago

Curious to know as well if this is still out of commission for ST3.

gja commented 10 years ago

I believe this feature (use scratch) still isn't working.

nicosantangelo commented 10 years ago

I've added begin_edit() / end_edit() support for ST3 by using run_command if the methods aren't available in my fork of the project. https://github.com/NicoSantangelo/sublime-text-2-ruby-tests/commit/a5e6a19167bbd06881b2f201601fd27c0539623f fixes "ruby_use_scratch" and "ruby_extract_variable" (related issue: #209).

If it's useful I could submit a pull request but I don't know if a branch for ST3 is on the works or if the idea was to provide support to both editors in with the same codebase.

Let me know :)

mariusbutuc commented 9 years ago

Any update on RubyTest working with Sublime Text 3?

danbartlett commented 9 years ago

Any hints on how to get this working with ST3?

jancel commented 9 years ago

Any updates?

ccurtisj commented 7 years ago

Bump - any update on scratch support?

apolzon commented 7 years ago

This was working for me prior to the update that installed today. Getting the same errors as posted above:

Traceback (most recent call last):
  File "run_ruby_test in /Users/apolzon/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package", line 60, in copy_stuff
  File "run_ruby_test in /Users/apolzon/Library/Application Support/Sublime Text 3/Installed Packages/RubyTest.sublime-package", line 49, in append
TypeError: begin_edit() missing 2 required positional arguments: 'edit_token' and 'cmd'
nicosantangelo commented 7 years ago

Hey @apolzon, I think the fork I posted a few comments up ( here ) continues to work.

I'm no longer using Ruby and don't intend to keep it as an official fork or anything. But seeing that this repo didn't have many updates lately, it might be a good replacement for anyone who may want to use it.