search

maltzj / google-style-precommit-hook

A pre-commit hook which will automatically format your code with google's codestyle guidelines!
56 stars 72 forks source link

Readme instructions are wrong - hash doesn't exist #26

Open berney opened 2 years ago

berney commented 2 years ago

The readme includes instructions:

repos:
- repo: https://github.com/maltzj/google-style-precommit-hook
  sha: b7e9e7fcba4a5aea463e72fe9964c14877bd8130
    hooks:
      - id: google-style-java

There is no hash b7e9e7fcba4a5aea463e72fe9964c14877bd8130 in this projects git history.

git fetch --all
git log --all | grep -i b7e9e7fcba4a5aea463e72fe9964c14877bd8130 --count
0

Also since pre-commit 1.7.0, it should be rev not sha.

It would be convenient to use tags for releases IMO, but SHAs have the benefit of being immutable. If they were correct.