mklink command fails silently

malxau / yori

Yori is a CMD replacement shell that supports backquotes, job control, and improves tab completion, file matching, aliases, command history, and more.

http://www.malsmith.net/yori/

MIT License

1.24k stars 31 forks source link

mklink command fails silently #20

Closed Migod11 closed 4 years ago

Migod11 commented 4 years ago

Well, title says it all: mklink /D does nothing ?

malxau commented 4 years ago

Thanks for the report. I pushed a fix for it now. The cause was mis-declaring the CreateSymbolicLink function as returning a 32 bit value instead of an 8 bit value; because return values are in registers, this means that if CreateSymbolicLink set the low 8 bits to zero (indicating failure) but any of the other 24 bits were nonzero, Yori would believe the call had succeeded rather than failed. Whether this occurs depends on other implementation details inside CreateSymbolicLink.

malxau commented 4 years ago

I just released 1.21 which I believe fixes this issue. You can upgrade an existing install with ypm -u. If you find any additional problems, please either reopen this issue or file a new one describing that problem. Thanks for the report!