malzariey / filament-daterangepicker-filter

MIT License
79 stars 39 forks source link

Improvements #38

Closed noxoua closed 10 months ago

noxoua commented 11 months ago

Initially, I only wanted to change the height of the field so that it looks harmonious with the rest of the fields.

Screenshot 2023-09-02 at 09 08 36

But then I decided to improve the component a little. Changes:

  1. Added Affixes.
  2. Removed calendar svg. (now this icon is displayed with a suffix)
  3. Replaced div with x-filament::input.wrapper component.
  4. Replaced input with x-filament::input component.
Screenshot 2023-09-02 at 10 52 28 Screenshot 2023-09-02 at 10 52 46
noxoua commented 11 months ago

I don't quite understand why the test fails. I didn't add any new dependencies. Maybe it's because of these imports: HasAffixActions, HasAffixes, HasExtraInputAttributes?

untillnesss commented 10 months ago

@noxoua I've pulled from your repo, but the changes you mentioned don't take effect.

image

I am irritated by this incongruity.

noxoua commented 10 months ago

@untillnesss Thank you for your comment! In your screenshot, I noticed that the field has a different icon (calendar). In my version, the icon was replaced. I also tried to reproduce and install a clean version of Laravel, Filament, and the package from my repository, the result is in the screenshots:

Screenshot 2023-09-13 at 14 55 41 Screenshot 2023-09-13 at 14 55 47

It looks like you installed the original package. Try the following steps:

  1. remove the package
  2. add priority to my repository
    "repositories": [
        {
            "url": "https://github.com/noxoua/filament-daterangepicker-filter",
            "type": "git"
        }
    ],
  3. install the package again
untillnesss commented 10 months ago

@noxoua I apologize in advance, I forgot, it turns out I had previously published the View file from this page, no wonder the View wouldn't change, after I deleted the View file that was published earlier, everything went well, thank you, good job!

malzariey commented 10 months ago

Thank you for your great PR, Merged