search

malzariey / filament-daterangepicker-filter

MIT License
75 stars 38 forks source link

DateRangePicker format is not adjust accordingly automatically when timepicker is enabled #83

Open Aamish26622 opened 1 month ago

Aamish26622 commented 1 month ago

When enabling timepicker, the $data did not included the time values nor the time was displayed on frontend unless we manually call displayFormat() and set the format accordingly.

Ideally, when one used timepicker() function on the DateRangePicker, it should automatically format it according (unless they have manully called displayFormat()).

Aamish26622 commented 1 month ago

Fixed in PR #82

now you can simply call timepicker() and the relavant function to automatically adjust the format without calling displayFormat

Aamish26622 commented 1 month ago

@majidalzariey any thoughts ?

malzariey commented 1 month ago

@Aamish26622 Thank you for your great PR, but I would prefer to resolve if any issue is available in the format with the getFormat() and getDisplayFormat rather than implementing alot of new variables.

Might as well introduce a new API to enforce the format as it is.