search

mamamia5x / markdownpedia

A site similar to Wikipedia written in Markdown.
https://markdownpedia.tk/
Other
16 stars 33 forks source link

Dark Theme #18

Open mamamia5x opened 3 years ago

mamamia5x commented 3 years ago

Create a pretty sweet looking dark theme. Something that Wikipedia doesn't have.

4rtmelly commented 3 years ago

Hi ! Can i work on this issue ? :)

mamamia5x commented 3 years ago

Yeah sure thing.

4rtmelly commented 3 years ago

Hey ! I made dark theme and added some div "card" for the picture of each contributors. Let me know if you like it or if you prefer to keep the table look. (I used bootstrap idk if it's fine ?) screen

mamamia5x commented 3 years ago

It looks great. Bootstrap is fine. Could you add a button to turn on darkmode? Like a moon button next to the search bar.

4rtmelly commented 3 years ago

Yeah sure i'm working on it !

4rtmelly commented 3 years ago

screenDark searchNormal

I used JS for the button dark/light mode. I worked in the markdowpedia/site/html repository and added a css & js repository to organized it, then modify the index.html How am I adding my code to this project now ?

mamamia5x commented 3 years ago

Create a pull request with the following code, and then I'll add it to the site once I get it up and running once again.

osBins commented 3 years ago

Hey @mamamia5x! I'd like to work on this issue! I don't see this feature yet on https://markdownpedia.tk/ Could you let me know if it's still active and needs to be worked on?

mamamia5x commented 3 years ago

Sure, do whatever you'd like.

osBins commented 3 years ago

Hey so I followed README.md to run markdownpedia locally on my system, but for some reason it formats incorrectly. image The commands I ran were npm install npm run convert npm run serve

  1. I request you to let me know what I'm doing wrong, to get the site to load correctly.
  2. I opened https://status.markdownpedia.tk/ from README.md and it doesn't seem to be working for me. Can you confirm?
mamamia5x commented 3 years ago

You did everything right, I created a script that tries to get the formatting to be the local URL, but it doesn't work properly, which is what is happening on your part. I'm trying to change some scripts for a new update, but there are some issues, and I haven't gotten back to this one. You can get rid of lines 102-115 in the vital/template.html file, but it may kill the search function.

The site I used to check status for markdownpedia recently made it a premium feature, and I'm not sure if I want to get it, I'll figure something out. If you have anymore questions, feel free to ask.

osBins commented 3 years ago

Great! Getting rid of lines 102-115 in vital/template.html worked. I've commented them for now. I'll uncomment them when I create a PR and it is ready to be merged.

mamamia5x commented 3 years ago

All right sounds good, thanks.

ramantamang777 commented 2 years ago

Hey! Can I work on it?

harshi606 commented 2 years ago

Hi ! I am interested to contribute . can you assign me the issue ?

bilalshaikh292 commented 2 years ago

hey, can I work on this project