search

mamantoha / crest

HTTP and REST client for Crystal
https://mamantoha.github.io/crest/
MIT License
235 stars 14 forks source link

why use my code for logger? #88

Closed icyleaf closed 6 years ago

icyleaf commented 6 years ago

i checked logger.cr and common_logger.cr both are 100% copy my halite code, why do that?

mamantoha commented 6 years ago

Hi @icyleaf.

Yeah, Logger is heavily inspired by (read: literally stolen) halite shard. Because I liked the idea of your code.

If I am not mistaken, it does not violate MIT license. So, the answer is "why not?".

By the way, 95% of the code copied from Ruby's rest-client gem.

icyleaf commented 6 years ago

First you broken the MIT License:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Second you copied from rest-client and write it to README, except halite.

That why i ask you.

mamantoha commented 6 years ago

Fixed in https://github.com/mamantoha/crest/commit/fdab83e0333c9d52b042662a6e467b24103057bb.

icyleaf commented 6 years ago

Thanks