search

mamaral / Neon

A powerful Swift programmatic UI layout framework.
MIT License
4.58k stars 389 forks source link

Fixed issue where the Groupable did not properly support AutoWidth and AutoHeight #34

Open dulbrich opened 8 years ago

dulbrich commented 8 years ago

Useful when making cards and you don't know how tall the text in the middle is going to be. screen shot 2016-05-26 at 4 21 47 pm

tim12s commented 8 years ago

Hi,

Can you add your ViewController as a test case - CardViewControllerDemo? Something like that.

Thanks -Tim

mamaral commented 8 years ago

As soon as I can I take a look at the details and update you, but on first glance I noticed how different the style/format is from the rest of the project. I'd like to keep everything consistent, i.e. parens around math to make order of operations clear to readers, declaring 0 as 0.0 to make reading it and recognizing it as a float clearer, spaces between operands like x / 2.0, etc.

dulbrich commented 8 years ago

Sorry for the slow response. My wife and I were welcoming our firstborn child into the world and everything else took the back burner...

@mamaral, I tried to match the style as best I could. Let me know if you'd like anything else changed.

@tim12s, I included an example of how one might create cards using only this library. screen shot 2016-06-02 at 1 19 10 pm

And for a bit of fun:

screen shot 2016-06-02 at 2 19 47 pm

mamaral commented 8 years ago

@dulbrich Congrats!! I've been quite busy as well, so I'll take a look at this once more as soon as I get a chance but the style fixes look perfect.

dulbrich commented 8 years ago

@mamaral

mamaral commented 8 years ago

@dulbrich A bunch has changed in the last couple of months - if you can resolve the conflicts I'll get it merged.