search

mamaral / Onboard

An iOS framework to easily create a beautiful and engaging onboarding experience with only a few lines of code.
MIT License
6.46k stars 764 forks source link

iPhone X Support? #190

Closed uetcis closed 6 years ago

uetcis commented 7 years ago
screen shot 2017-10-02 at 11 04 42 am

In iPhone X, the onboard view's page controller is not keeping a correct distance from the indicator, and this is not recommended by Apple

rlam3 commented 7 years ago

Would be nice if we can get a swift 4 upgrade and iPhone X support for this. Thanks!

uetcis commented 7 years ago

@rlam3 actually this framework is based on Objective-C.......

dasvibes commented 7 years ago

Having this same issue , anyone know the quick fix for it ?

hanandika commented 7 years ago

edit OnboardingContentViewController.h file ? see line num.27 static CGFloat const kDefaultUnderPageControlPadding = 0; add your own padding only for iphone-x

jriiringan commented 7 years ago

up for iPhone X support

ddaddy commented 6 years ago

I'm having layout issues on iPhone X. Even the demo doesn't seem to fill the screen and the page control is too high. simulator screen shot - iphone x - 2018-01-17 at 15 19 55