search

mamaral / Onboard

An iOS framework to easily create a beautiful and engaging onboarding experience with only a few lines of code.
MIT License
6.46k stars 765 forks source link

Just some warnings in regards to integer conversions. #3

Closed evanstoddard closed 10 years ago

evanstoddard commented 10 years ago

You were using NSUInteger for the blur method and that resulted in a warning. Basically it was looking for an unsigned int. I changed it to unsigned int radius instead of NSUInteger * radius which removed the warning and didn't have any adverse affects.

mamaral commented 10 years ago

Yeah the blur code needs some work, it looks pretty good for some photos, but not all, and I'll likely be replacing it with another implementation soon. Thank you!

evanstoddard commented 10 years ago

I think it looks pretty good. Before iOS 8 I used this:https://github.com/ivoleko/ILTranslucentView I had a great deal of luck and memory usage wasn't too bad. I use the native UIVisualEffectView and I love it. Again... not too terrible with resources. The visual effect view is probably better the ILTranslucentView because the IL project subclasses the toolbar I think. So thats an extra reference. Hope I was able to help a little bit. I just hate warnings ;)

mamaral commented 10 years ago

Just looked into the UIVisualEffectView, and I surprisingly like the way the current implementation looks. I think I still need to tweak it a bit, we'll see.

For some reason Xcode didn't give me those warnings, but I'll take your word for it as I probably disabled them for some reason in the past... I'll need to fix that. https://github.com/mamaral/Onboard/commit/a72fd144ffe2bc150f19dbc8dab4870b75147e49 should take care of that. Thanks!

evanstoddard commented 10 years ago

Ok. Glad it’s working out. The warnings weren’t too big of a deal. It was mainly my OCD. It seemed to work the same either way.

On Sep 11, 2014, at 10:38 PM, Mike Amaral notifications@github.com wrote:

Just looked into the UIVisualEffectView, and I surprisingly like the way the current implementation looks. I think I still need to tweak it a bit, we'll see.

For some reason Xcode didn't give me those warnings, but I'll take your word for it as I probably disabled them for some reason in the past... I'll need to fix that. commit:a72fd144ffe2bc150f19dbc8dab4870b75147e49 should take care of that.

— Reply to this email directly or view it on GitHub https://github.com/mamaral/Onboard/issues/3#issuecomment-55355189.