search

mamaral / Onboard

An iOS framework to easily create a beautiful and engaging onboarding experience with only a few lines of code.
MIT License
6.46k stars 765 forks source link

Added auto-sizing of icon based on image #33

Closed Vortec4800 closed 9 years ago

Vortec4800 commented 9 years ago

I don't know how you feel about this, given it could be done from outside of the framework by setting the size properties based on the image file, but it seemed like something the framework could do pretty easily and would make for sensible defaults.

Changed the default icon size to be pulled from the icon file, instead of using the hardcoded default size. Icon sizes can still be overridden using the properties for those who need this functionality.

Also I didn't make this change on the Swift side of things. Don't know if that's a big deal or not.

mamaral commented 9 years ago

The swift thing is not too big of an issue, unfortunately I've let that sort of slip a bit behind the objective-c side of things as I haven't had the time to adequately learn the language. I like this idea though, once travis finishes running I'll go ahead and merge it. Thanks for the contribution!

Vortec4800 commented 9 years ago

Sure thing, glad I could help. I'll probably have a few other feature updates that you may or may not like as well.