mamaral / xkcd-Open-Source

A free and open source xkcd comic reader for iOS.
MIT License
255 stars 45 forks source link

Comic 1608 Broke It #33

Closed zevlag closed 8 years ago

zevlag commented 8 years ago

There are no new comics appearing in the app after comic #1607.

mamaral commented 8 years ago

Seems you're right. I'll have @fergusean take a look at the server/db and see whats up. Thanks @zevlag !

zevlag commented 8 years ago

I imagine that we are getting an exception from this line: https://github.com/mamaral/xkcd-Open-Source/blob/master/cache-server/update-server.php#L203

The JSON for 1608 looks like this:

{"month": "11", "num": 1608, "link": "", "year": "2015", "news": "", "safe_title": "Hoverboard", "transcript": "My new book, Thing Explainer, comes out today! To celebrate, here's a small game.\n\n[[A stick figure on a hoverboard can navigate around a field with platforms and barriers, reminiscent of a pinball machine, from top to bottom and left to right. Along the way it can collect coins, and then deposit them in a little terminal down at the center of the bottom. When you do, a message reads, \"You got X coins in Y seconds!\" and a secondary message depending on how well you did. \nX=0 \"You successfully avoided all the coins!\"\nX=1 \"It's a start.\"\nX=2-4 \"Not bad.\"\nX=5-9 \"Terrific!\"\nX=10-16 (No message.)\nX=17 \"You found all the coins! Great job!\"\n\nHowever, if you leave the bounds of the playing field in either direction, a message in large red letters will flash:\nRETURN TO THE PLAY AREA\n\nWhen you keep going, you discover a vast world with grassy fields, caverns, mountains, volcanoes, and buildings. There are many little vignettes hidden everywhere, along with more coins.]]\n{{Title text: Return to the play area}}", "alt": "Return to the play area", "img": "http:\/\/imgs.xkcd.com\/comics\/", "title": "Hoverboard", "day": "24"}
mamaral commented 8 years ago

Yup, that's what we were thinking - good catch.

fergusean commented 8 years ago

Image URL isn't valid. Points to a 404. Suggestions on how to handle?

mamaral commented 8 years ago

Ignore for now or screenshot website and manually enter into db :)

fergusean commented 8 years ago

Hosted a screenshot of 1608 in a fork of the repo and manually injected 1608 into the DB. I'll patch the PHP to handle that comic's edge case and PR. Until next time...

mamaral commented 8 years ago

Thanks @zevlag!