search

mamaral / xkcd-Open-Source

A free and open source xkcd comic reader for iOS.
MIT License
256 stars 45 forks source link

Save Image on iOS crashes 100% of the time #86

Open computer2467 opened 5 years ago

computer2467 commented 5 years ago

REPRO: Go to any comic, tap the share button, tap the save image button.

SPECS: iPhone X, iOS v12.3.1 App version v2.5

Sent with GitHawk

Kamik423 commented 5 years ago

I had an issue in an app of mine where something similar would happen, because the app has get permission to save an image. StackOverflow.

This might be related. In my case the app crashed immediately, xkcd:OS however freezes.

Looking through the code: this seems to be in there already:

https://github.com/mamaral/xkcd-Open-Source/blob/c23cb9db60a714a3c7d9ca3899d5a610868a24be/Source/Misc/Supporting%20Files/Info.plist#L72-L73

However as of iOS 11 the key NSPhotoLibraryAddUsageDescription seems to be more applicable.

TL;DR:

I thought this was it, but it is not. So you can cross this off your list.