mamatt / files_readmemd

Show README.md & HEADER.md in the file view of NextCloud
GNU Affero General Public License v3.0
12 stars 5 forks source link

Images not being showed #33

Closed mamatt closed 1 year ago

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 10, 2019, 19:41

Not sure if it's supposed to work or not but adding an image with a link to an image on nextcloud doesn't show the image.

Would really like to be able to show an image at the top of a directory.

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 11, 2019, 09:29

This is normally working out of the box....

Can you give me more information about you're MD file ?

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 14, 2019, 21:03

What would you like to see, an example? attached screenshots of the editted file with text app, and the HEADER.md itselfHEADER.md

1

2

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 14, 2019, 21:05

I see that HEADER.md refers to /core/preview?fileId=78881&x=1024&y=1024&a=true#mimetype=image%2Fpng&hasPreview=true&fileId=78881

which I'm not sure is right..

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 15, 2019, 09:37

I see that ou are using the new text editor !
It handle image differently than we can do be hand.

I've made a fix. I should published an updated version soon.

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 15, 2019, 10:04

@matthieu.lecorre awesome, thanks!

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 16, 2019, 11:53

Fix by 6da7dc43

I should publish a new version by the end of the week

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 16, 2019, 11:53

closed

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 18, 2019, 16:09

reopened

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 18, 2019, 16:11

I updated to 1.1.2 but still not able to insert images through the new text app. hereby the HEADER.md. The image is in the same folder as where I want to show it. The image is called affordable and clean energy.png. HEADER.mdenergy_sdg

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 23, 2019, 11:57

this is definitely strange.
I've tested with such filename and did not get any issue.

Can you check is the console (F12 for chrome) if there is any error ?

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 23, 2019, 12:01

hum, you header.md seems also strange !
The url for the image is starting from /core !

Do you have a non standard installation ?

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 23, 2019, 20:38

I think I have a standard installation, used this guide: https://www.c-rieger.de/nextcloud-installation-guide-ubuntu/ I've done several installations based on this excellent installation guide. I tested two with Readmemd, both are giving the same error.

No erors on the console, what should the URL be? To the image I mean.

Really would like to resolve this because I think the functionality is awesome, I could create testaccount for you on one of the installations.

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 24, 2019, 09:23

oh I see, you have setup url rewrite .. I try to handle those case !

Can you give the result of those 3 commande in your console :

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 24, 2019, 21:33

sure:

OC.generateUrl("test")

"/test"

OC.linkToRemoteBase("test")

"/remote.php/test"

OC.getRootPath()

""

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Oct 25, 2019, 12:38

Found it !

Fix by 22a123d627906d8e639ffd3a5f8732c17d18427c

I'll try to publish a new version in 2 weeks

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Oct 26, 2019, 11:07

Very cool, thank you, much appreciated

mamatt commented 4 years ago

In GitLab by @Omaha2002 on Nov 18, 2019, 09:45

Hi Matthieu, any change of releasing an update? Really would like this functionality to work. I know it's free time work so absolutely no pressure.. :-)

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Nov 18, 2019, 09:47

hum, I'm working on fixing issues #35 et #36.

I'll publish a new version as soon as I manage to fix those issues ;)

mamatt commented 4 years ago

In GitLab by @matthieu.lecorre on Nov 25, 2019, 17:52

closed