search

mamayuan / pe

0 stars 0 forks source link

Id being case-sensitive #5

Open mamayuan opened 11 months ago

mamayuan commented 11 months ago

ID is currently case-sensitive. Even if case insensitivity is allowed. Some warning messages should be issued about this. image.png

nus-pe-bot commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate detection not extending to lowercase

As can be seen in the following screenshot, two entries with the exact same details save a single lowercase/uppercase letter in the ID can be created.

image.png

This may not have been a major concern, but for the target audience (employers), it's unlikely that uppercase and lowercase IDs will be distinct from each other (i.e. A0001 will almost definitely be the same person as a0001). I would recommend including a case-insensitive checker for duplicates.

[original: nus-cs2103-AY2324S1/pe-interim#578] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your input.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]