Closed hbcarlos closed 4 years ago
jtpio
commented
4 years ago The dependencies are not correct we need to get the dependencies of the packages to show them.
Maybe there are some parts that can be ported from the previous backend: https://github.com/mamba-org/mamba-navigator/blob/master/server/list_and_query.py
hbcarlos
commented
4 years ago I improved the graph and add it to the package manager. For now, we can open the dependencies graph for a package by clicking on his version (we should change that later)
hbcarlos
commented
4 years ago I applied all the changes except for:
Should we handle directly here the fact that mamba will be able to render the graph but not conda? What happen for not installed packages?
Take a look and let me know if there is something wrong.
hbcarlos
commented
4 years ago I'll look at the test tonight or tomorrow.
coveralls
commented
4 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| mamba_gator/handlers.py | 4 | 5 | 80.0% | ||
| mamba_gator/envmanager.py | 1 | 16 | 6.25% | ||
| <!-- | Total: | 5 | 21 | 23.81% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/services.ts | 130 | 46.48% | ||
| <!-- | Total: | 130 | --> |
| Totals | |
|---|---|
| Change from base Build 364212499: | -1.7% |
| Covered Lines: | 745 |
| Relevant Lines: | 1002 |
fcollonval
commented
4 years ago 
:point_left: Launch a binder notebook on the branch hbcarlos/gator/master
fcollonval
commented
4 years ago Great work @hbcarlos
I have two requests regarding the style:
--jp-ui-font-size0? The current 8px is quite small.hbcarlos
commented
4 years ago Sure, it's done. I'll do a new commit.
Regarding:
The idea is to add an icon in the toolbar above the packages list (it will be absent if mamba is not available - or disabled with a title advertising mamba 😉 ). On click on the button, this would open the dependency panel (not sure if on the right of the package list is a good place or if it needs to be a separated panel to allow positioning and resize by the user).
Do you want to do it in this PR or open a new one?
hbcarlos
commented
4 years ago Thanks, @fcollonval. I completely agree with those suggestions. You can commit them and merge the PR.
coveralls
commented
4 days ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| mamba_gator/handlers.py | 4 | 5 | 80.0% | ||
| mamba_gator/envmanager.py | 2 | 16 | 12.5% | ||
| <!-- | Total: | 6 | 21 | 28.57% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| mamba_gator/handlers.py | 4 | 94.09% | ||
| mamba_gator/envmanager.py | 12 | 86.01% | ||
| src/services.ts | 130 | 46.48% | ||
| <!-- | Total: | 146 | --> |
| Totals | |
|---|---|
| Change from base Build 364212499: | -1.6% |
| Covered Lines: | 750 |
| Relevant Lines: | 1006 |
coveralls
commented
4 days ago This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| mamba_gator/handlers.py | 4 | 5 | 80.0% | ||
| mamba_gator/envmanager.py | 2 | 16 | 12.5% | ||
| <!-- | Total: | 6 | 21 | 28.57% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| mamba_gator/handlers.py | 4 | 94.09% | ||
| mamba_gator/envmanager.py | 16 | 84.97% | ||
| src/services.ts | 130 | 46.48% | ||
| <!-- | Total: | 150 | --> |
| Totals | |
|---|---|
| Change from base Build 364212499: | -1.9% |
| Covered Lines: | 746 |
| Relevant Lines: | 1006 |
A graph to visualize packages #83 The dependencies are not correct we need to get the dependencies of the packages to show them.
I'm reusing the code from jupyterlab-plugin-graph