mamba-org / gator

Conda environment and package management extension from within Jupyter
Other
260 stars 31 forks source link

Move some of the dev dependencies to the top level #114

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

Fixes #112

github-actions[bot] commented 3 years ago

Binder :point_left: Launch a binder notebook on the branch mamba-org/gator/fcollonval/issue112

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 388789937


Totals Coverage Status
Change from base Build 388773498: 0.0%
Covered Lines: 745
Relevant Lines: 1002

💛 - Coveralls
jtpio commented 3 years ago

Thanks @fcollonval!

Do you think it would also make sense to move the eslint and prettier scripts to the top-level?

For example:

https://github.com/mamba-org/gator/blob/0ad6ce7f9a73577bb9503ba64e59e12271e5952c/packages/labextension/package.json#L35-L36

fcollonval commented 3 years ago

Do you think it would also make sense to move the eslint and prettier scripts to the top-level?

Sure, maybe specifying packages as the folder argument