search

mamba-org / gator

Conda environment and package management extension from within Jupyter
Other
259 stars 31 forks source link

feat: remove conda-store environment #173

Closed gabalafou closed 2 years ago

gabalafou commented 2 years ago

Closes Quansight/conda-store#141.

Per conda-store API docs.

Note: this PR is against conda-store-integration branch, not the main branch.

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on the branch Quansight/gator/delete-conda-store-environment

fcollonval commented 2 years ago

Kicking the CI

fcollonval commented 2 years ago

Do you mind rebasing the PR on master @gabalafou ?

fcollonval commented 2 years ago

Kicking the CI

fcollonval commented 2 years ago

It seems your code need linting. Could you run jlpm run eslint and commit the changes please?

gabalafou commented 2 years ago

@fcollonval you sure? I ran jlpm run eslint but it didn't change anything or produce any lint errors. I then pulled latest from main branch, I reinstalled with pip install -e ., I did yarn install, and ran jlpm run eslint. Nothing.

gabalafou commented 2 years ago

There's some difference between master and conda-store-integration branches: https://github.com/mamba-org/gator/compare/master..conda-store-integration

including eslint config difference, maybe that has something to do with the discrepancy between CI and my local dev env?

But I also rebased this branch against master and re-ran the whole install -> eslint cycle and got nothing, so I'm out of ideas :grin:

fcollonval commented 2 years ago

You are right @gabalafou the error is not on your code but on conda-store-integration branch. I push a correction. Now we should be in a better state.

fcollonval commented 2 years ago

Would you mind rebasing this PR on mamba-org:conda-store-integration