mamba-org / gator

Conda environment and package management extension from within Jupyter
Other
260 stars 30 forks source link

Metadata for environment name is not correct here #74

Closed fcollonval closed 4 years ago

fcollonval commented 4 years ago

That statement is wrong:

https://github.com/fcollonval/jupyter_conda/blob/a7fd182a6b6a47a7ca48b545ba946e2937fcf4b1/labextension/src/validator.ts#L215-L217

The environment name set by nb_conda_kernels is built from the env directory basename. But some element are added to make it unique. So actually here what is needed is to use the directory basename from the path metadata.

https://github.com/Anaconda-Platform/nb_conda_kernels/blob/7422ba97c732e792b9afb92ebe0316102c20606e/nb_conda_kernels/manager.py#L132

Note: The API is therefore maybe wrong to handle environments with similar names but different prefix.