search

mamba-org / gator

Conda environment and package management extension from within Jupyter
Other
264 stars 29 forks source link

Use navigator in the classical notebook #97

Closed fcollonval closed 4 years ago

fcollonval commented 4 years ago

Address item 4 of https://github.com/mamba-org/gator/issues/88#issuecomment-721679209

This build on top of #95

After thinking a bit more about it, as the classical notebook is based on tab views and that the navigator provide an standalone usable view, I decided to drop the classical notebook code to only keep link opening the navigator.

One frontend to rule them all 💍 😉

What do you think @jtpio ?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 357759915

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 357666190: 0.1%
Covered Lines: 741
Relevant Lines: 976
💛 - Coveralls
jtpio commented 4 years ago

Nice!

One frontend to rule them all

Yes that's pretty much the idea. In general this could be a good way for packages that used to ship both classic and lab extensions to transition to a single code base. Using modern JS / TS and tooling.

jtpio commented 4 years ago

I decided to drop the classical notebook code to only keep link opening the navigator.

So that means skipping the warning step?

fcollonval commented 4 years ago

So that means skipping the warning step?

The legacy integration is:

legacy_nb_integration

This PR proposal:

classical_nb_integration

As the entry points are the same between the legacy and this PR integration, I propose to skip the warning step.

jtpio commented 4 years ago

Looks good!