Use navigator in the classical notebook

mamba-org / gator

Conda environment and package management extension from within Jupyter

Other

260 stars 30 forks source link

Use navigator in the classical notebook #97

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

Address item 4 of https://github.com/mamba-org/gator/issues/88#issuecomment-721679209

This build on top of #95

After thinking a bit more about it, as the classical notebook is based on tab views and that the navigator provide an standalone usable view, I decided to drop the classical notebook code to only keep link opening the navigator.

One frontend to rule them all 💍 😉

What do you think @jtpio ?

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 363238244

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.731%

Totals
Change from base Build 358185947:	0.0%
Covered Lines:	741
Relevant Lines:	972

💛 - Coveralls

jtpio commented 3 years ago

Nice!

One frontend to rule them all

Yes that's pretty much the idea. In general this could be a good way for packages that used to ship both classic and lab extensions to transition to a single code base. Using modern JS / TS and tooling.

jtpio commented 3 years ago

I decided to drop the classical notebook code to only keep link opening the navigator.

So that means skipping the warning step?

fcollonval commented 3 years ago

So that means skipping the warning step?

The legacy integration is:

legacy_nb_integration

This PR proposal:

classical_nb_integration

As the entry points are the same between the legacy and this PR integration, I propose to skip the warning step.

jtpio commented 3 years ago

Looks good!