mamba-org / mamba

The Fast Cross-Platform Package Manager
https://mamba.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.68k stars 346 forks source link

feat: allow underscores anywhere in token #3210

Closed wolfv closed 5 months ago

wolfv commented 5 months ago

The token format on anaconda is wo-1234-asdf-123123 (UUID4 style). The first two letters are derived from the user name (e.g. wolfv in my case).

On prefix.dev, we use something like pfx_1234asdf123123.... We are now changing this to use - as well (to maximize compatibility). I think _ is still better because it allows tokens to be easier selected e.g. in a browser / text-editor.

LMK what you think! :)

AntoinePrv commented 5 months ago

We can add this but I don't think it's what you want. These regexs only get used in the logging to hide credentials. What you want is in CondaURL (although I am not sure there are such limitations)

wolfv commented 5 months ago

We actually changed it on the prefix.dev side to accomodate conda & mamba. So I think we can also close this one for now.