search

mamba-org / mamba

The Fast Cross-Platform Package Manager
https://mamba.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.53k stars 342 forks source link

OCI/Conda mapping #3310

Closed Hind-M closed 3 weeks ago

Hind-M commented 1 month ago

Map packages names starting with _ to match OCI registries rules (and CEP)

wolfv commented 1 month ago

Did you do an end-to-end test yet? Because I was pretty confused that this ever worked before (since _libgcc_mutex is basically in all Linux environments and starts with an underscore) :)

Hind-M commented 3 weeks ago

LGTM except for the anonymous namesapce.

Please review https://github.com/mamba-org/mamba/pull/3307 first, as this PR is based on it.

Hind-M commented 3 weeks ago

Did you do an end-to-end test yet? Because I was pretty confused that this ever worked before (since _libgcc_mutex is basically in all Linux environments and starts with an underscore) :)

I added a check on mamba list output after creating the test env, and it's using _go_select instead of _libgcc_mutex now.

Klaim commented 3 weeks ago

@wolfv (When names are "reserved" it implies that the "implementation" is allowed to use them, they are reserved to avoid conflicts mainly, so I suppose _libgcc_mutex is considered part of the "implementation" as it's part of the OS API? That would explain it.)

EDIT: oh wait, you're talking in the url, I thought it was about the actual mutex, nevermind XD