search

mamba-org / mamba

The Fast Cross-Platform Package Manager
https://mamba.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6.96k stars 359 forks source link

maint: Enable `-Werror` compiler flag for GCC, Clang and AppleClang #3611

Closed mathbunnyru closed 4 days ago

mathbunnyru commented 1 week ago

I think we can now enable -Werror flag relatively easily when building with GCC, Clang and AppleClang.

I tested locally on my M2 Mac with the following compilers:

In some places I turned errors back to warnings, in some - disabled, I will explain choices using commenting.

Fix: https://github.com/mamba-org/mamba/issues/3542

mathbunnyru commented 5 days ago

@jjerphan @Klaim I think I fixed all the comments (and a bit more), so please, take a look.