mamba-org / powerloader

BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Added a way to check if there was downloading errors #136

Closed Klaim closed 1 year ago

Klaim commented 1 year ago

This is part of mamba integration.

wolfv commented 1 year ago

I would also not mind using std::optional instead of pointers.

Klaim commented 1 year ago

@wolfv I would prefer that too indeed, but the member being a std::unique_ptr so I followed that logic. I will look into the details see if we can just return the error object by value, I suspect there is an issue preventing that.