search

mamba-org / powerloader

BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Create `DownloadTarget` properly and never store duplicates `Mirror`s. #140

Closed Klaim closed 1 year ago

Klaim commented 1 year ago

Switching to draft because I'm not super convinced by this last commit, but it's an attempt at having a way to not insert mirrors which are the same for the same host. An improvement over this would be to completely make the map an opaque type, not a global map, so that it cannot be possible to insert a mirror without that check. I considered it but had to revert to this because there is a lot to change to get there, including the python usage. However if some agree here I will do the effort.

Klaim commented 1 year ago

There is one last issue to fix for making this work with the libmamba integration, working on it.

Klaim commented 1 year ago

This should be sufficient to use in the libmamba integration PR, or so I think.