search

mamba-org / powerloader

BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Proxy handling #152

Closed wolfv closed 1 year ago

wolfv commented 1 year ago

Note: to make tests pass in mamba, we still need to implement the SSL stuff for CURLHandle.

Klaim commented 1 year ago

@wolfv I can work on the changes needed if you don't have the time to update this.

Note that I tested this PR as is with the current mamba integration PR and that seems to fix all the tests (except the ones that were always failing even with main) on my linux. I didn´t try on Windows yet.

Klaim commented 1 year ago

So I removed the issue with the global by making the CURLSetup instance part of the Context (which is already forced to have exactly one instance) and made it easy to pass options to the context so that it does the right thing.

At this point, LGTM, other than the CI not passing for static build I think we can merge. Adding @JohanMabille for review if he find the time too.

wolfv commented 1 year ago

Looks good to me, thanks for pushing your changes!

Klaim commented 1 year ago

@wolfv If you have an occasion to test this on macos with last comits on mamba integration pr? if that works well for you and I manage to make it work for windows then we're probably "good enough"

Klaim commented 1 year ago

I'll update this PR