Splitted build configuration, build and tests steps

mamba-org / powerloader

BSD 3-Clause "New" or "Revised" License

15 stars 9 forks source link

Closed JohanMabille closed 1 year ago

JohanMabille commented 1 year ago

The build CI shared / test (windows-latest should fail (this is expected and will be fixed in a dedicated PR). cc @Klaim

Klaim commented 1 year ago

LGTM 👍🏽 (context for others: the ci failing on windows/shared is what we want)

Suggestion: adding -fvisibility=hidden in https://github.com/mamba-org/powerloader/blob/main/CMakeLists.txt#L173 so that non-msvc builds also fail as expected.

JohanMabille commented 1 year ago

Now every "share" build should fail

Klaim commented 1 year ago

Just the shared build, yes