search

mamba-org / setup-micromamba

GitHub Action to set up micromamba
MIT License
97 stars 15 forks source link

Include bin hash in cache key #228

Closed bhperry closed 8 hours ago

bhperry commented 1 day ago

Add sha256 hash of the micromamba binary to the cache key so broken environments created from previous versions won't be restored for a new version.

Closes https://github.com/mamba-org/setup-micromamba/issues/91

pavelzw commented 1 day ago

Could you also compile the action and bump its version in package.json?

bhperry commented 1 day ago

Could you also compile the action and bump its version in package.json?

@pavelzw minor bump for this?

pavelzw commented 1 day ago

Sure 👍🏻

bhperry commented 1 day ago

Is test.sh outdated? Tried to run it, but no index.js in dist

pavelzw commented 1 day ago

Yes seems like it 🤔 I nowadays just run the tests from GitHub ci

pavelzw commented 1 day ago 

Error: src/cache.ts(43,22): error TS2339: Property 'readBinaryFile' does not exist on type 'typeof import("fs/promises")'.
bhperry commented 1 day ago

hmm looked that one up somewhere, guess I was looking at the wrong fs package

bhperry commented 1 day ago

seems like regular readFile with no encoding should do the trick

pavelzw commented 10 hours ago

The ci failures look unrelated. I'll take a look at them later

pavelzw commented 8 hours ago

the remaining failing ci is tracked in #230