Issue:
It is best to use native architecture for the Apple Silicon if available. For some native binaries, e.g. pytorch, it is critical to use correct architecture, due to the use of architecture specific CPU extensions in the builds
Solution:
Extend download functions for mac to match CPU architecture of VSCode Update tests to download x64 and arm64
Add downloaded binary architecture check for macOS
Note:
I have explored using file-type package for checking file on all the platforms. The package is capable of identifying needed architectures for linux and windows, it doesn't work for macOS. Moreover it is ESM only package and doesn't work in this repo which is using CJS
Issue: It is best to use native architecture for the Apple Silicon if available. For some native binaries, e.g. pytorch, it is critical to use correct architecture, due to the use of architecture specific CPU extensions in the builds
Solution: Extend download functions for mac to match CPU architecture of VSCode Update tests to download x64 and arm64 Add downloaded binary architecture check for macOS
Note: I have explored using
file-typepackage for checking file on all the platforms. The package is capable of identifying needed architectures for linux and windows, it doesn't work for macOS. Moreover it is ESM only package and doesn't work in this repo which is using CJS