search

mambax7 / adslight

Adslight is a classifieds module that allow users of XOOPS website to advertise items for sale, exchange or barter.
2 stars 1 forks source link

Error in sending images #5

Closed cesagonchu closed 3 years ago

cesagonchu commented 3 years ago

When I send an image for an ad, on the user side, it does not appear, there is a transparent thumbnail instead. When I edit the ad, it tells me that there is no image. I don't get any error message.

I then tried to send an image, on the admin side. I then get this error, when I click on the image thumbnail: Error: Class 'XoopsModules/Adslight/Pictures' not found in file /modules/adslight/class/PicturesHandler.php line 213

EDIT: the image for my test can be found here: https://stocksnap.io/photo/car-vehicle-R1CC86SYG2 I also tested with a small image 3kb and 225x225, still the same problem.

mambax7 commented 3 years ago

Thanks for reporting it. I'll look into it this weekend

cesagonchu commented 3 years ago

Two users are waiting to update Adslight on their website. Did you make any progress?

mambax7 commented 3 years ago

Should finish this weekend, as the latest.

mambax7 commented 3 years ago

This is still not done and not fully tested, but you can take a look at the current updated code I'll continue to work on it on the weekend

cesagonchu commented 3 years ago

Following your changes, I found a new error: https://github.com/mambax7/adslight/issues/6#issue-1025567754

We are making progress, that's the main thing. 👍🏻

mambax7 commented 3 years ago

Are the images now working? If yes, could you close it?

cesagonchu commented 3 years ago

No. After checking "yes" to "Do you want to add Photos Now" and clicking the submit button, it takes me back to the website home page.

cesagonchu commented 3 years ago

Following your modifications, no change. The attempt to add an image sends us back to: /modules/adslight/index.php

mambax7 commented 3 years ago

That's weird, because it worked here. Could you email me access to your Website so I can test it there?

cesagonchu commented 3 years ago

I will test within this week with a fresh Xoops. Ideally, someone else should help us with the tests.

cesagonchu commented 3 years ago

Okay, I see what the problem is. When I add an image for an ad by clicking on the green button, it works. /modules/adslight/add.php

When I add an image by selecting a category, that's when it doesn't work. /modules/adslight/viewcats.php?cid=25 /modules/adslight/addlisting.php?cid=25

mambax7 commented 3 years ago

Thanks for narrowing it down. I'll work on this use case as well. Unfortunately, the code is messy, as there were several different developers rewriting parts of it over several years, so there are different styles and approaches mixed in, and sometimes it's hard to follow the logic. But we'll get there :)

cesagonchu commented 3 years ago

Yes, I believe in you! :-P

cesagonchu commented 3 years ago

It works now thank you! :-)

mambax7 commented 3 years ago

Finally! :)