search

mambax7 / tag

The Tag module is designed for site-wide tag management, handling tag input, display and stats for each module that enables tag plugin.
2 stars 3 forks source link

bloc top and bloc cloud #15

Closed alain01 closed 2 years ago

alain01 commented 2 years ago

the paramaters in block admin are not read

Top tag

Number to display: Try to change this parameter and ... nothing change Sort Criteria Same

Tag cloud

Number to display: Try to change this parameter and ... nothing change

mambax7 commented 2 years ago

Should be now fixed in https://github.com/mambax7/tag/commit/6fc3a657da832a46166dca71086cd887bbfb2771

This is how it looked in my test:

image

alain01 commented 2 years ago

Please re-open... Dont close until I have tested it, please. My first tests with php 7.3 for the moment.

Block Tag cloud : Number to display: Display ok till 9 1 => 1 is displayed ... 9 => 9 Then 10 => 9 11=>9 12 =>10 13=>11 14 =>12 15 => 12 16 => 13 17 => 14 18 => 15 19 => 16 etc

Block Top Tag Sort Criteria: Ok now Number to display: 1 =>1 is displayed ... 8 => 8 9 => 8 10 => 9 11 => 10 12 => 11 13 => 12 14 => 12 15 => 12 ... 18 => 12

So Max 12 and pb after 8.

mambax7 commented 2 years ago

You can always re-open yourself, that's not a problem!

alain01 commented 2 years ago

ok ;-)

mambax7 commented 2 years ago

Could not replicate it with Publisher. I tested with both 20, and then 10 (Cloud Block) and 15 (Top Tag Block):

image

alain01 commented 2 years ago

Ok, I dont know... but i get the problem. I will test without xmnews, just with publisher...

alain01 commented 2 years ago

Ok Please REOPEN !

Please test with just 1 module, for example, publisher ! All is ok ! Then add xmenws, now we get these troubles

Now, desactivate publisher, update tag, all is ok ok with xmnews (just xmnews) Then add publisher, Now, we get the same problem

So, the problem is not publisher, the problem is not xmnews, the problem appears when there is more than one module working with the tag module !

mambax7 commented 2 years ago

You should be able to reopen it yourself, don't you? If there is a problem, please re-open!

alain01 commented 2 years ago

I cant reopen, I have just the "comment" button Capture d’écran 2021-12-20 162256

mambax7 commented 2 years ago

Hmm, that strange! OK, I'll reopen!

mambax7 commented 2 years ago

Or you can open a new one :) But which one issues do we still have here?

Is it this one?

image

alain01 commented 2 years ago

yes

mambax7 commented 2 years ago

I hope, this will finally fix it :) https://github.com/mambax7/tag/commit/f07f7b291a4abf6ecd00e7414747b5765b3d679d

alain01 commented 2 years ago

Awesome !!!

It works now ! You delete 1 word in the PHP/Sql code and all is ok now ? !!! (, l.tag_modid)

Bravo et merci pour cette recherche et pour la correction du bug, Mamba. Encore bravo !