search

mambax7 / xoopspoll

The XoopsPolls module can be used to display interactive survey forms on your site. Each poll can display a question on which visitors can ‘vote’.
0 stars 3 forks source link

xoopspoll/admin/main.php fails #10

Open walkero-gr opened 1 week ago

walkero-gr commented 1 week ago

Hello there, Today I updated one of my websites to Xoops 2.5.11 and I am trying to use XoopsPoll from this repostory. This is under the same upgrade I am trying to do with the discussion we had at https://github.com/XoopsModules25x/newbb/issues/128

When I try to visit the https://github.com/XoopsModules25x/newbb/issues/128 page I get the following error. Fatal error: Property of type XoopsModules\Xoopspoll\Common\mixed may not have default value in /var/www/html/modules/xoopspoll/class/Common/Configurator.php on line 28

Also visiting one of the old polls at /modules/xoopspoll/pollresults.php?poll_id=16 I get the following error Error : TypeError: Return value of XoopsModules/Xoopspoll/Option::getStaticOptHandler() must be an instance of XoopsModules/Xoopspoll/mixed, instance of XoopsModules/Xoopspoll/OptionHandler returned

Trying to create a new poll at /modules/newbb/polls.php?op=add&forum=13 I get the following error Fatal error: require_once(): Failed opening required '/var/www/html/modules/xoopspoll/include/constants.php' (include_path='.:/usr/local/lib/php') in /var/www/html/modules/newbb/polls.php on line 88

I also upgraded to PHP 7.4, since this module requires it.

walkero-gr commented 1 week ago

Testing with different versions of PHP, I managed to have most of the above pages working, except of creating a new poll, either from admin or frontendm using newbb. I get the following fatal error

Error : TypeError: XoopsModules/Xoopspoll/OptionHandler::renderOptionFormTray(): Argument #1 ($pid) must be of type int, null given, called in /modules/xoopspoll/class/Poll.php on line 332

Although I understand that there is a need to use the latest versions of PHP, having the module not supporting older versions, not even 7.4 or 8.0, is problematic. There should not be any expectation that people will have a xoops website working fine on php 8.3 when most of us use modules that are not maintained any more.

I find it quite difficult to keep up using Xoops when most of the features are not working as advertised, and the luck of working modules makes the whole situation a nightmare. I still have bugs that require in-depth knowledge of the platform. Whenever I find a problem I can fix, I try to contribute back with PRs and reporting them.

I do not want to sound negative, but it is like nothing is tested, and there is no stable path in the platform, making us loosing a lot of hours trying to make it work as it should.

mambax7 commented 1 week ago

Thank you for the info. I'll look into it this week/weekend, and will make sure that it works on PHP 7.4, as this is the minimum version that will be supported by XOOPS 2.5.12

mambax7 commented 1 day ago

@walkero-gr Sorry, didn't have time to get to it. I'll try tonight...

walkero-gr commented 1 day ago

@mambax7 No worries at all. Take your time.