mame / wsl2-ssh-agent

A bridge from WSL2 ssh client to Windows ssh-agent.exe service
MIT License
102 stars 6 forks source link

Reimplement repeater.ps1 #7

Closed Hill-98 closed 11 months ago

Hill-98 commented 11 months ago

6

Hill-98 commented 11 months ago

@mame I made some modifications to repeater.ps1, but I have a new version of OpenSSH installed locally and cannot effectively test it. Can you test whether it handles extended messages correctly?

mame commented 11 months ago

Thanks, but it did not work. Looks like $buf is Null. I have no time to debug it now. Sorry.

$ ./wsl2-ssh-agent -foreground -verbose | nkf -u -Sw
[L] 2023/12/02 18:47:20 start listening on /home/mame/.ssh/wsl2-ssh-agent.sock
[L] 2023/12/02 18:47:20 invoking [W] in PowerShell.exe
[W] 2023/12/04 11:16:31 ssh-agent.exe version: 8.6.0.1 (ignoreOpenSSHExtensions: True)
[W] 2023/12/04 11:16:31 ready: PSVersion 5.1.22621.2506
[L] 2023/12/02 18:47:21 [W] invoked successfully
[L] 2023/12/02 18:47:23 ssh: connected
[L] 2023/12/02 18:47:23 ssh -> [L] (212 B)
[L] 2023/12/02 18:47:23 [L] -> [W] (212 B)
[W] 2023/12/04 11:16:32 [W] named pipe: connected
[W] 2023/12/04 11:16:33 [L] -> [W] -> ssh-agent.exe (212 B)
[W] 2023/12/04 11:16:33 [L] <- [W] <- ssh-agent.exe (0 B)
[W] 2023/12/04 11:16:33 [W] named pipe: disconnected
wsl2-ssh-agent.ps1: terminated
"3" 個の引数を指定して "Write" を呼び出し中に例外が発生しました: "値を Null にすることはできません。
パラメーター名:buffer"
発生場所 行:35 文字:5
+                 $ssh_client_out.Write($buf, 0, $buf.Length)
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : ArgumentNullException
mame commented 11 months ago

Also, to make my review easier, it would be nice if you could please not include irrelevant changes, or at least separate commits.

Hill-98 commented 11 months ago

Fixed the above issue, and I tested it successfully on OpenSSH 8.6.

Hill-98 commented 11 months ago

@mame Do you have any other comments? If not, can it be merged?

mame commented 11 months ago

Yeah, merged. Thanks!

mame commented 11 months ago

Ah, go test fails. I didn't set up GitHub Actions...

Hill-98 commented 11 months ago

Looks like I forgot to modify the test.