Closed cclauss closed 7 years ago
Have to take some time to review this (and learn to build tests to assure the "alt" function produces the intended result). Big thanks for your support tidying the code. The long if blocks are a result of the one-o-one port of the DuckEncoder Hava implementation. It included even logical errors, as I want to have the exact same functionality. Should have rebuilt it from scratch. What is the benefit of changing the print function to future? Is that all what has to be done to get python 3 ready?
Understood. No rush.
The advantage there are two advantages to putting in the future bit:
end
and file
work the same in both Py2 and Py3It is unclear if these are the last changes that are required to by Python 3 compatible but no issues were picked up by flake8 or by my eyeballs -- but neither is perfect.
Thanks again for your support
altReadResource() uses a generator and a dict comprehension to do what readResource() does but I can not be 100% sure that it handles all corner cases so I left readResource() in place for now.
or