search

mamedev / mame

MAME
https://www.mamedev.org/
Other
7.95k stars 1.98k forks source link

nintendo/punchout.cpp: sound not quite right #10628

Open DJIncendration1 opened 1 year ago

DJIncendration1 commented 1 year ago

The sound and stereo positioning in a few games is a bit complicated and not quite right. I've noticed it most in Punch-Out, Super Punch-Out and Arm Wrestling. Some may be hard to tell for the average listener, some are easy to tell. The biggest example that's easy to tell is when Dragon Chan does his kick in Super Punch-Out!! When he throws his kick, there is supposed to be a whoosh sound that gets rather loud. On Mame (including version 250), there is almost no sound at all. The sound that is there does not sound anything like it. There are other issues that occur in both Punch-Out and Super Punch-Out. The voice is on the left side on Mame, but on the right side on original hardware. The counting speed is a bit fast on Mame, and the sound as the opponent falls is about the same as the NES knockdown sound. In Arm Wrestling, the laugh when you don't get the money is fast and has a pause in the middle on Mame. Here are videos captured from hardware from Punch-Out!! and Super Punch-Out!!. https://www.youtube.com/watch?v=IEahziptyuo https://www.youtube.com/watch?v=cNB0S5mdMnc Here is a video of Arm Wrestling on an actual arcade machine (note that the man who made the video is talking while the laugh happens; I couldn't find a run captured directly from the hardware).) https://www.youtube.com/watch?v=HdVOXHcs4iI Here are videos recorded from Mame (note: these videos were played on older versions, but the sound is the same on 250.) https://www.youtube.com/watch?v=GpII2b-licY https://www.youtube.com/watch?v=NkCICvuJh8E https://www.youtube.com/watch?v=-BX-8iBpsfw To reproduce these issues: for the sound when the opponent is about to fall: just knock an opponent like Glass Joe down (usually a normal punch works better for reproducing this) for Dragon Chan's kick sound: play through the game until Dragon Chan (2nd fight.) Dodge or do something until Dragon Chan does his kick. to compare the voice: enter initials at the start of Punch-Out or Super Punch-Out.

0kmg commented 1 year ago

These sorts of bug reports should be done at https://mametesters.org. In fact some of them are.

There are several issues here and they may be separate.

DJIncendration1 commented 1 year ago

Yes, I'm referring to the whistle sound. The Dragon Chan kick actually has a punch sound on one speaker for both the arcade and Mame. It's the other speaker that's incorrect on Mame. I did not know that the whistle sound happens as the opponent flies through the air, because I am completely blind. It doesn't seem to be variable on Mame, but it is slightly variable, I think, on original arcade hardware. I am also not familiar with a lot of the letter and number stuff like VLM5030. I will report future bugs I encounter (if I encounter more while playing) to the other site.

On Sat, Dec 3, 2022 at 2:17 PM 0kmg @.***> wrote:

These sorts of bug reports should be done at https://mametesters.org. In fact some of them are.

There are several issues here and they may be separate.

  • The stereo left/right issue is a trivial fix.
  • The Dragon Chan kick is the weirdest, since it sounds like it's coming from the VLM5030 in the arcade footage but it sounds like MAME is making a punching sound on the 2A03 (opposite speaker). This is a known bug: https://mametesters.org/view.php?id=959
  • Counting speed in Punch-Out is also a known issue: https://mametesters.org/view.php?id=8122
  • Arm Wrestling laugh speed issue is not reported yet, but probably related to Punch-Out counting speed (VLM5030 issue).
  • Which falling sound are you talking about? The high pitched twirling whistle sound as the opponent flies through the air? Isn't this sound supposed to be variable? It's not clear to me what I'm listening for here.

— Reply to this email directly, view it on GitHub https://github.com/mamedev/mame/issues/10628#issuecomment-1336222456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGOE5LYUZZTRXTPYWSNJURLWLOMFJANCNFSM6AAAAAASSQHTFY . You are receiving this because you authored the thread.Message ID: @.***>

0kmg commented 1 year ago

@DJIncendration1 Thanks for the follow up. I adjusted my left/right volume and can hear the "punch" sound on the other speaker when Dragon Chan kicks. So it's not so weird after all and I stand corrected.

Don't worry about the letters and numbers. Those are just chip names and there for whomever may be able to fix the bugs. I still can't tell what may be wrong with the falling sound, but I'll keep it on my radar since those are letters and numbers I've contributed to a tiny bit ;)