apple2: Video-7 RGB DGHR monochrome mode behaves like mixed mode

[inexorabletash]

MAME version

0.252 via Ample

System information

macOS 13.2.1 M1 MacBook Air

Emulated system/software

apple2ee

Incorrect behaviour

Recent updates have caused the apple2 Video-7 RGB double-hire mode 1 (monochrome 560x192) to behave the same as mode 3 (mixed). That is, bytes with the high bit set produce color output instead of monochrome.

mame64 apple2ee -skip_gameinfo -nosamples -window -nomax -video bgfx -sl4 '' -flop1 'DHGR_RGB_Mode_Tests.dsk' -nothrottle

When the system is running, in Machine Configuration, select Monitor Type: Video-7 RGB

Try the attached disk image:

DHGR_RGB_Mode_Tests.dsk.zip

The program loads a DHGR image and switches to DHGR mode 2 (COLOR 140x192). Press 1 to switch to mode 1 (MONOCHROME 560x192). Note that with the latest MAME there are color blocks rather than the entire display being monochrome. This is due to high bits set in the image, and is how mode 3 should display, not mode 1.

Expected behaviour

In mode 1 the display should be entirely in monochrome. This is a regression from previous MAME builds.

Steps to reproduce

No response

Additional details

No response

[inexorabletash]

@rb6502 - I think you can best triage this.

[xotmatrix]

MAME (monochrome appears identical to mixed mode)

AppleWin (expected monochrome result)

[inexorabletash]

FYI, Karateka image c/o http://lukazi.blogspot.com/2017/03/double-high-resolution-graphics-dhgr.html

[rb6502]

@benrg any ideas on this before I dive in?

[benrg]

I'm sure it's my fault. I'll look at it.

[rb6502]

@benrg were you able to look at this? Release freeze is Saturday so I need to know if I have to fix this myself.

[rb6502]

This has now been resolved. The same typo also broke IIgs monochrome DHGR and selecting "B&W" as the monitor type.

[inexorabletash]

Thanks! (I thought that line looked sketchy but I'm not set up to build.)

[rb6502]

It was actually a bit sketchier than that - there's a better fix in 2ea68c9 :-)