search

mamedev / mame

MAME
https://www.mamedev.org/
Other
7.75k stars 1.95k forks source link

rendersw: Generate cosine table at compile time #12513

Closed FlykeSpice closed 1 day ago

rb6502 commented 2 days ago

This looks reasonable to me, but compile-time execution is a bit beyond my daily-driver C++ subset so I'm going to defer to whichever of @cuavas or @galibert for the final call.

galibert commented 1 day ago

I love it, didn't even realize that was possible that readibly. But it needs to be tested for all the minimal versions of compilers we support, including the visual studio stuff...

rb6502 commented 1 day ago

@pmackinlay I think you use MSVC? Can you check that this compiles there?

MooglyGuy commented 1 day ago

Please disregard my previous comment which I have now deleted, as it was in error; the diff didn't quite apply correctly against my local changes.

This compiles just fine on MSVC 2022.