Ncr5385 fix for missing raising IRQ for INT_INVALID_CMD

mamedev / mame

MAME

https://www.mamedev.org/

Other

7.75k stars 1.95k forks source link

Ncr5385 fix for missing raising IRQ for INT_INVALID_CMD #12524

Open Elektraglide opened 2 days ago

Elektraglide commented 2 days ago

Tek4404 issues cmd=0xff which expects an IRQ even though its an INT_INVALID_CMD
minor readability; replaced magic hex value with symbolic names

cuavas commented 2 days ago

Also, please give the pull request a meaningful title. What does it change? What does it fix?

Elektraglide commented 15 hours ago

Also, please give the pull request a meaningful title. What does it change? What does it fix?

Title amended. In large code base like this, I've generally used PR titles to give 'area of interest' for reviewers and used following lines to explain the details. But if having a detailed title is the MAME thang, happy to go with it. :-)