mamedev / mame

MAME
https://www.mamedev.org/
Other
7.76k stars 1.95k forks source link

casio/pv1000.cpp: wrong naming for the sound device #12527

Open angelosa opened 6 days ago

angelosa commented 6 days ago

DEFINE_DEVICE_TYPE(PV1000, pv1000_sound_device, "pv1000_sound", "NEC D65010G031")

Declares a misleading PV1000 device that should be a PV1000_SOUND at very least, also the (μP?)D65010G031 is actually a gate array, configured for sound in this context but not necessarily a sound device (i.e. Casio FP-200 reuses it for video instead).

happppp commented 6 days ago

Did you open an issue because you wanted to discuss first? This is a 1-minute commit to correct it =) Yes it looks like the device name should be PV1000_SOUND, and the string something like "Casio PV1000 Sound"

angelosa commented 6 days ago

Did you open an issue because you wanted to discuss first?

Yeah, that's the idea :)

lidnariq commented 5 days ago

Photo of the FP-200 PCB shows that the gate array is µPD65010G030, the immediate previous order.

cuavas commented 5 days ago

There are lots of poorly named sound devices in MAME where the device type name implies it’s the whole system.