search

mamedev / mame

MAME
https://www.mamedev.org/
Other
8.06k stars 2.01k forks source link

Re-implement TMS-36xx organ synthesiser chip emulation #392

Open Osso13 opened 9 years ago

Osso13 commented 9 years ago

laserbat.cpp is the last user of the former.

cuavas commented 8 years ago

The trouble is tms36xx is manifestly inadequate at the moment. It can only generate 12 of the 13 tones, the way it calculates the dividers isn't even close to correct it takes a clock in kHz when the rest of MAME uses clocks in Hz, and it doesn't do one rank of outputs. tms3615 is slightly better in terms of what it does, but it can't handle capacitors on the key inputs, external reset, or separate routing of the 8' and 16' outputs. Also the tms36xx code is structured horribly. The tune generator stuff should be in a derived class. It would almost be better to improve tms3615 and then make derived classes of that for the related chips.

angelosa commented 3 years ago

Related files:

By quick look neither device is adequate by C++ OO standards, and issue title should be among the lines of Make a new tms36xx device implementation super class, @cuavas ?