search

mamedev / mame

MAME
https://www.mamedev.org/
Other
8.05k stars 2.01k forks source link

request to add Donkey Kong variation (with patch :) ) #752

Closed 2011 closed 8 years ago

2011 commented 8 years ago

Hi,

Hope this is the right place for this.

On Jeff's Rom Hack, there is a page (actually can't find it from the site, but search engines list it) that describes how user actions affect whether or not a barrel comes down a ladder.

http://jeffsromhack.com/products/donkeykong_tech.htm

He has edited a ROM (that he will send upon request) that changes the color of barrels that the player has caused to come down a ladder. This is mostly a demonstration / learning tool, but I actually enjoy playing with it, and do so frequently. For a long time, I just ignored the ROM mismatch error in MAME, but then the checking became strict, and I actually had to go in and patch the source code. I have a reasonable aptitude for that, but I am not an expert by any means (I don't work with code or in technology).

After I recently upgraded MAME (to 0.168), I thought about seeing if I could ask to have this hack included in the regular source code (so I wouldn't have to patch it myself every time :) ). I have never submitted a real patch to an open source project before, so this is my first go at it. I have nicknamed this hack dkongbcc (for something like Donkey Kong with barrel control coloring).

Hope that somebody else finds this worthwhile.

--- src/mame/arcade.lst  2015-11-25 10:01:04.000000000 +0000
+++ src/mame/arcade.lst  2016-02-15 00:00:00.000000000 +0000
@@ -1233,6 +1233,7 @@
 dkongj          // (c) 1981 Nintendo
 dkongjo         // (c) 1981 Nintendo
 dkongjo1        // (c) 1981 Nintendo
+dkongbcc        // hack from Jeff's Romhack (barrel control color)
 dkongf          // hack from Jeff's Romhack
 dkongpe         // hack Pauline Edition
 dkongx          // hack
--- src/mame/drivers/dkong.cpp  2015-11-25 10:01:06.000000000 +0000
+++ src/mame/drivers/dkong.cpp  2016-02-15 00:00:00.000000000 +0000
@@ -2013,7 +2013,36 @@
        ROM_LOAD( "c-2j.bpr",     0x0100, 0x0100, CRC(d6412358) SHA1(f9c872da2fe8e800574ae3bf483fb3ccacc92eb3) ) /* palette high 4 bits (inverted) */
        ROM_LOAD( "v-5e.bpr",     0x0200, 0x0100, CRC(b869b8f5) SHA1(c2bdccbf2654b64ea55cd589fd21323a9178a660) ) /* character color codes on a per-column basis */
 ROM_END
-
+
+ROM_START( dkongbcc )
+       ROM_REGION( 0x10000, "maincpu", 0 )
+       ROM_LOAD( "c_5et_g.bin",  0x0000, 0x1000, CRC(eec71586) SHA1(8c9c05c919265d6b930e5088e869c4b44264ded4) )
+       ROM_LOAD( "c_5ct_g.bin",  0x1000, 0x1000, CRC(49200edb) SHA1(e40a19700196dc7b2ae766cbef51867856c986aa) )
+       ROM_LOAD( "c_5bt_g.bin",  0x2000, 0x1000, CRC(56f7c409) SHA1(265817ce17951d49b95a2361c5cc3032620aae96) )
+       ROM_LOAD( "c_5at_g.bin",  0x3000, 0x1000, CRC(03b56372) SHA1(fea19bb4c46c88c26943ccd910b560cecd5dc44c) )
+       /* space for diagnostic ROM */
+
+       ROM_REGION( 0x1800, "soundcpu", 0 ) /* sound */
+       ROM_LOAD( "s_3i_b.bin",   0x0000, 0x0800, CRC(45a4ed06) SHA1(144d24464c1f9f01894eb12f846952290e6e32ef) )
+       ROM_RELOAD(               0x0800, 0x0800 )
+       ROM_LOAD( "s_3j_b.bin",   0x1000, 0x0800, CRC(4743fe92) SHA1(6c82b57637c0212a580591397e6a5a1718f19fd2) )
+
+       ROM_REGION( 0x1000, "gfx1", 0 )
+       ROM_LOAD( "v_5h_b.bin",   0x0000, 0x0800, CRC(12c8c95d) SHA1(a57ff5a231c45252a63b354137c920a1379b70a3) )
+       ROM_LOAD( "v_3pt.bin",    0x0800, 0x0800, CRC(15e9c5e9) SHA1(976eb1e18c74018193a35aa86cff482ebfc5cc4e) )
+
+       ROM_REGION( 0x2000, "gfx2", 0 )
+       ROM_LOAD( "l_4m_b.bin",   0x0000, 0x0800, CRC(59f8054d) SHA1(793dba9bf5a5fe76328acdfb90815c243d2a65f1) )
+       ROM_LOAD( "l_4n_b.bin",   0x0800, 0x0800, CRC(672e4714) SHA1(92e5d379f4838ac1fa44d448ce7d142dae42102f) )
+       ROM_LOAD( "l_4r_b.bin",   0x1000, 0x0800, CRC(feaa59ee) SHA1(ecf95db5a20098804fc8bd59232c66e2e0ed3db4) )
+       ROM_LOAD( "l_4s_b.bin",   0x1800, 0x0800, CRC(20f2ef7e) SHA1(3bc482a38bf579033f50082748ee95205b0f673d) )
+
+       ROM_REGION( 0x0300, "proms", 0 )
+       ROM_LOAD( "c-2k.bpr",     0x0000, 0x0100, CRC(e273ede5) SHA1(b50ec9e1837c00c20fb2a4369ec7dd0358321127) ) /* palette low 4 bits (inverted) */
+       ROM_LOAD( "c-2j.bpr",     0x0100, 0x0100, CRC(d6412358) SHA1(f9c872da2fe8e800574ae3bf483fb3ccacc92eb3) ) /* palette high 4 bits (inverted) */
+       ROM_LOAD( "v-5e.bpr",     0x0200, 0x0100, CRC(b869b8f5) SHA1(c2bdccbf2654b64ea55cd589fd21323a9178a660) ) /* character color codes on a per-column basis */
+ROM_END
+
 ROM_START( dkongo )
        ROM_REGION( 0x10000, "maincpu", 0 )
        ROM_LOAD( "c_5f_b.bin",   0x0000, 0x1000, CRC(424f2b11) SHA1(e4f096f2bbd37281f42a5f8e083738f55c07f3dd) )    /* tkg3c.5f */
@@ -3315,6 +3344,7 @@

 GAME( 1981, dkong,     0,        dkong2b,   dkong,    driver_device, 0,        ROT90,  "Nintendo of America", "Donkey Kong (US set 1)", MACHINE_SUPPORTS_SAVE )
 GAME( 1981, dkonghrd,  dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  "Nintendo of America", "Donkey Kong (hard kit)", MACHINE_SUPPORTS_SAVE ) // not sure if original or bootleg (see notes on top of driver file)
+GAME( 1981, dkongbcc, dkong,    dkong2b,  dkong, driver_device,          0,  ROT90, "hack", "Donkey Kong (US set 1 with barrel control coloring)", MACHINE_SUPPORTS_SAVE )
 GAME( 1981, dkongo,    dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  "Nintendo", "Donkey Kong (US set 2)", MACHINE_SUPPORTS_SAVE )
 GAME( 1981, dkongj,    dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  "Nintendo", "Donkey Kong (Japan set 1)", MACHINE_SUPPORTS_SAVE )
 GAME( 1981, dkongjo,   dkong,    dkong2b,   dkong,    driver_device, 0,        ROT90,  "Nintendo", "Donkey Kong (Japan set 2)", MACHINE_SUPPORTS_SAVE )
stilett0 commented 8 years ago

It's far more likely we'll redirect this to a spin-off project called HBMAME. For now, regarding homebrew and hacks, MAME only focuses those that actually lived a life in the arcades. This fails to qualify. Attention @Robbbert :smiley: http://hbmame.1emulation.com/

NULUSIOS commented 8 years ago

This is indeed something for HBMAME.

Robbbert commented 8 years ago

2011: It can be added to HBMAME if you want. If you are a member at mameworld.info you need to PM me there privately for further instructions.

Robbbert commented 8 years ago

Nothing further heard, closing.

Robbbert commented 5 years ago

This set has been added to HBMAME 0.214