mamezou-tech / setup-helmfile

Setup helmfile action
MIT License
41 stars 20 forks source link

chore: allow pulling helmfile releases from new helmfile repository #40

Closed philomory closed 2 years ago

philomory commented 2 years ago

Also bumps the default versions of all tools.

Uses the semver-compare library to check whether we are installing version 0.145.0 or later; if so, we use the new repository. Otherwise, we use the old repository.

philomory commented 2 years ago

Ah, I realize the problem now: I forgot to include dist/index.js in the commit; which, I mean, it says right there in the readme :facepalm:

philomory commented 2 years ago

Actually, no, there are more problems. I guess in my excitement over the new release I didn't realize they'd also switched to uploading tarballs rather than binaries, and also have changed the filename format.

Having a single action that supports both the old and new repositories may be a bit more cumbersome than I initially thought.

kondoumh commented 2 years ago

Thank you for the pull request. I saw the CI log. The HTTP status is 404 at the time of download.

##[debug]Failed to download from "https://github.com/helmfile/helmfile/releases/download/v0.145.0/helmfile_linux_amd64". Code(404) Message(Not Found)
(node:1609) UnhandledPromiseRejectionWarning: Error: Unexpected HTTP response: 404
    at /home/runner/work/setup-helmfile/setup-helmfile/dist/index.js:3831:[25](https://github.com/mamezou-tech/setup-helmfile/runs/7121662968?check_suite_focus=true#step:3:26)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/setup-helmfile/setup-helmfile/dist/index.js:3741:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
kondoumh commented 2 years ago

I was able to download it from this URL with curl.

https://github.com/helmfile/helmfile/releases/download/v0.145.0/helmfile_0.145.0_linux_amd64.tar.gz

philomory commented 2 years ago

Hmmm. Can you push dist/index.js as well?

Done. I don't think I will ever learn to remember to rebuild generated files before pushing 🤦‍♂️