search

mammadataei / cypress-vite

Run Cypress specs using Vite
MIT License
85 stars 10 forks source link

override any manualChunks from the user config #58

Closed SIGSTACKFAULT closed 1 year ago

SIGSTACKFAULT commented 1 year ago

low effort solution, but works. fixes #57.

mammadataei commented 1 year ago

@SIGSTACKFAULT Thanks for your contribution.

Typescript is not happy with the false value. Can you please check whether using undefined fixes the issue?

SIGSTACKFAULT commented 1 year ago

...and it doesn't actually work when it's undefined. only false seems to work. I figured anything vaguely falsey would work.

SIGSTACKFAULT commented 1 year ago

{} and () => void don't work either because they exist for the purpose of the checks despite not doing anything

mammadataei commented 1 year ago

Oh, I thought it worked with undefined. If it only works with false, then it might be a typing issue. I will open a new issue and create a new pull request to fix it.