search

mammo0 / docker-arkime

A Docker container for Arkime based on Ubuntu
MIT License
28 stars 17 forks source link

fix dependency issues #19

Closed acadian42 closed 4 months ago

acadian42 commented 4 months ago

This pull request addresses dependency issues encountered during the Docker build process for Arkime. Specifically, it ensures that all required dependencies are installed before attempting to install the Arkime package. This change should prevent errors related to missing dependencies.

mammo0 commented 4 months ago

Hello, at first thank you for the contribution.

But it is intended that the command dpkg -i "${ARKIME_DEB_PACKAGE}" || true fails. This ensures that apt-get install -yqf installs all required dependencies and one does not need to specify them first. This has the advantage that I do not need to check for changed dependencies after every Arkime update.

If you have a better idea of how to install the Arkime deb file without manually installing the required dependencies before, just let me know :) Otherwise I will close this PR.

PS: You changed a lot of lines in your PR. Not only the one that are required for specifying the Arkime dependencies. For example you fixed some typos in comments and removed the unnecessary ARG UBUNTU_VERSION line. It would be better if you create separate commits for those changes.

acadian42 commented 4 months ago

That makes sense and I did not consider changed dependencies after Arkime update.