search

mammon-ircd / mammon

legacy-free IRCv3.2 server built ontop of ircreactor
http://www.mammon.io/
ISC License
29 stars 4 forks source link

Trailing space in CAP NAK #54

Open progval opened 8 years ago

progval commented 8 years ago

At the end of CAP NAK responses, Mammon adds a trailing space:

Why?

Also, the spec states “The argument of the NAK subcommand MUST consist of at least the first 100 characters of the capability list in the REQ subcommand which triggered the NAK.”, and this space is not in the original message, so to my understanding, this is invalid.

progval commented 8 years ago

Note: git blame says: https://github.com/mammon-ircd/mammon/commit/45b0c5ff34b494ce283f5599eb05d545ab69d6ff

DanielOaks commented 8 years ago

If mIRC's fixed their client, we can take that out. We'll do some testing and see if it's still required!

Mikaela commented 8 years ago

I think this is breaking ZNC as when I connect I see:

2015-12-20 09:46:16+0200 -- *: C :Unknown command
2015-12-20 09:46:16+0200 -- *: AP :Unknown command
2015-12-20 09:46:16+0200 -- Welcome to the dereferenced.org IRC Network, Mikaela!mikaela@Ace-of-Diamonds.GirlsLikeUs.mikaela.info

And when I run /cap with WeeChat, I see just list of what ZNC supports.

2015-12-20 09:50:34+0200 -- irc: client capability, server supports: batch cap-notify echo-message multi-prefix server-time userhost-in-names znc.in/batch znc.in/playback znc.in/self-message znc.in/server-time-iso
2015-12-20 09:50:34+0200 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names
Mikaela commented 8 years ago

No, sorry, I missed the "NAK" in the tittle, I am opening a separate issue.